pax_global_header00006660000000000000000000000064125312155570014520gustar00rootroot0000000000000052 comment=34babcb58126a416fcf5205768204f2e12699dda on-finished-2.3.0/000077500000000000000000000000001253121555700137255ustar00rootroot00000000000000on-finished-2.3.0/.gitignore000066400000000000000000000000441253121555700157130ustar00rootroot00000000000000coverage node_modules npm-debug.log on-finished-2.3.0/.travis.yml000066400000000000000000000003441253121555700160370ustar00rootroot00000000000000language: node_js node_js: - "0.8" - "0.10" - "0.12" - "1.0" - "1.8" - "2.0" - "2.1" sudo: false script: "npm run-script test-travis" after_script: "npm install coveralls@2 && cat ./coverage/lcov.info | coveralls" on-finished-2.3.0/HISTORY.md000066400000000000000000000032361253121555700154140ustar00rootroot000000000000002.3.0 / 2015-05-26 ================== * Add defined behavior for HTTP `CONNECT` requests * Add defined behavior for HTTP `Upgrade` requests * deps: ee-first@1.1.1 2.2.1 / 2015-04-22 ================== * Fix `isFinished(req)` when data buffered 2.2.0 / 2014-12-22 ================== * Add message object to callback arguments 2.1.1 / 2014-10-22 ================== * Fix handling of pipelined requests 2.1.0 / 2014-08-16 ================== * Check if `socket` is detached * Return `undefined` for `isFinished` if state unknown 2.0.0 / 2014-08-16 ================== * Add `isFinished` function * Move to `jshttp` organization * Remove support for plain socket argument * Rename to `on-finished` * Support both `req` and `res` as arguments * deps: ee-first@1.0.5 1.2.2 / 2014-06-10 ================== * Reduce listeners added to emitters - avoids "event emitter leak" warnings when used multiple times on same request 1.2.1 / 2014-06-08 ================== * Fix returned value when already finished 1.2.0 / 2014-06-05 ================== * Call callback when called on already-finished socket 1.1.4 / 2014-05-27 ================== * Support node.js 0.8 1.1.3 / 2014-04-30 ================== * Make sure errors passed as instanceof `Error` 1.1.2 / 2014-04-18 ================== * Default the `socket` to passed-in object 1.1.1 / 2014-01-16 ================== * Rename module to `finished` 1.1.0 / 2013-12-25 ================== * Call callback when called on already-errored socket 1.0.1 / 2013-12-20 ================== * Actually pass the error to the callback 1.0.0 / 2013-12-20 ================== * Initial release on-finished-2.3.0/LICENSE000066400000000000000000000022171253121555700147340ustar00rootroot00000000000000(The MIT License) Copyright (c) 2013 Jonathan Ong Copyright (c) 2014 Douglas Christopher Wilson Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the 'Software'), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. on-finished-2.3.0/README.md000066400000000000000000000114261253121555700152100ustar00rootroot00000000000000# on-finished [![NPM Version][npm-image]][npm-url] [![NPM Downloads][downloads-image]][downloads-url] [![Node.js Version][node-version-image]][node-version-url] [![Build Status][travis-image]][travis-url] [![Test Coverage][coveralls-image]][coveralls-url] Execute a callback when a HTTP request closes, finishes, or errors. ## Install ```sh $ npm install on-finished ``` ## API ```js var onFinished = require('on-finished') ``` ### onFinished(res, listener) Attach a listener to listen for the response to finish. The listener will be invoked only once when the response finished. If the response finished to an error, the first argument will contain the error. If the response has already finished, the listener will be invoked. Listening to the end of a response would be used to close things associated with the response, like open files. Listener is invoked as `listener(err, res)`. ```js onFinished(res, function (err, res) { // clean up open fds, etc. // err contains the error is request error'd }) ``` ### onFinished(req, listener) Attach a listener to listen for the request to finish. The listener will be invoked only once when the request finished. If the request finished to an error, the first argument will contain the error. If the request has already finished, the listener will be invoked. Listening to the end of a request would be used to know when to continue after reading the data. Listener is invoked as `listener(err, req)`. ```js var data = '' req.setEncoding('utf8') res.on('data', function (str) { data += str }) onFinished(req, function (err, req) { // data is read unless there is err }) ``` ### onFinished.isFinished(res) Determine if `res` is already finished. This would be useful to check and not even start certain operations if the response has already finished. ### onFinished.isFinished(req) Determine if `req` is already finished. This would be useful to check and not even start certain operations if the request has already finished. ## Special Node.js requests ### HTTP CONNECT method The meaning of the `CONNECT` method from RFC 7231, section 4.3.6: > The CONNECT method requests that the recipient establish a tunnel to > the destination origin server identified by the request-target and, > if successful, thereafter restrict its behavior to blind forwarding > of packets, in both directions, until the tunnel is closed. Tunnels > are commonly used to create an end-to-end virtual connection, through > one or more proxies, which can then be secured using TLS (Transport > Layer Security, [RFC5246]). In Node.js, these request objects come from the `'connect'` event on the HTTP server. When this module is used on a HTTP `CONNECT` request, the request is considered "finished" immediately, **due to limitations in the Node.js interface**. This means if the `CONNECT` request contains a request entity, the request will be considered "finished" even before it has been read. There is no such thing as a response object to a `CONNECT` request in Node.js, so there is no support for for one. ### HTTP Upgrade request The meaning of the `Upgrade` header from RFC 7230, section 6.1: > The "Upgrade" header field is intended to provide a simple mechanism > for transitioning from HTTP/1.1 to some other protocol on the same > connection. In Node.js, these request objects come from the `'upgrade'` event on the HTTP server. When this module is used on a HTTP request with an `Upgrade` header, the request is considered "finished" immediately, **due to limitations in the Node.js interface**. This means if the `Upgrade` request contains a request entity, the request will be considered "finished" even before it has been read. There is no such thing as a response object to a `Upgrade` request in Node.js, so there is no support for for one. ## Example The following code ensures that file descriptors are always closed once the response finishes. ```js var destroy = require('destroy') var http = require('http') var onFinished = require('on-finished') http.createServer(function onRequest(req, res) { var stream = fs.createReadStream('package.json') stream.pipe(res) onFinished(res, function (err) { destroy(stream) }) }) ``` ## License [MIT](LICENSE) [npm-image]: https://img.shields.io/npm/v/on-finished.svg [npm-url]: https://npmjs.org/package/on-finished [node-version-image]: https://img.shields.io/node/v/on-finished.svg [node-version-url]: http://nodejs.org/download/ [travis-image]: https://img.shields.io/travis/jshttp/on-finished/master.svg [travis-url]: https://travis-ci.org/jshttp/on-finished [coveralls-image]: https://img.shields.io/coveralls/jshttp/on-finished/master.svg [coveralls-url]: https://coveralls.io/r/jshttp/on-finished?branch=master [downloads-image]: https://img.shields.io/npm/dm/on-finished.svg [downloads-url]: https://npmjs.org/package/on-finished on-finished-2.3.0/index.js000066400000000000000000000071461253121555700154020ustar00rootroot00000000000000/*! * on-finished * Copyright(c) 2013 Jonathan Ong * Copyright(c) 2014 Douglas Christopher Wilson * MIT Licensed */ 'use strict' /** * Module exports. * @public */ module.exports = onFinished module.exports.isFinished = isFinished /** * Module dependencies. * @private */ var first = require('ee-first') /** * Variables. * @private */ /* istanbul ignore next */ var defer = typeof setImmediate === 'function' ? setImmediate : function(fn){ process.nextTick(fn.bind.apply(fn, arguments)) } /** * Invoke callback when the response has finished, useful for * cleaning up resources afterwards. * * @param {object} msg * @param {function} listener * @return {object} * @public */ function onFinished(msg, listener) { if (isFinished(msg) !== false) { defer(listener, null, msg) return msg } // attach the listener to the message attachListener(msg, listener) return msg } /** * Determine if message is already finished. * * @param {object} msg * @return {boolean} * @public */ function isFinished(msg) { var socket = msg.socket if (typeof msg.finished === 'boolean') { // OutgoingMessage return Boolean(msg.finished || (socket && !socket.writable)) } if (typeof msg.complete === 'boolean') { // IncomingMessage return Boolean(msg.upgrade || !socket || !socket.readable || (msg.complete && !msg.readable)) } // don't know return undefined } /** * Attach a finished listener to the message. * * @param {object} msg * @param {function} callback * @private */ function attachFinishedListener(msg, callback) { var eeMsg var eeSocket var finished = false function onFinish(error) { eeMsg.cancel() eeSocket.cancel() finished = true callback(error) } // finished on first message event eeMsg = eeSocket = first([[msg, 'end', 'finish']], onFinish) function onSocket(socket) { // remove listener msg.removeListener('socket', onSocket) if (finished) return if (eeMsg !== eeSocket) return // finished on first socket event eeSocket = first([[socket, 'error', 'close']], onFinish) } if (msg.socket) { // socket already assigned onSocket(msg.socket) return } // wait for socket to be assigned msg.on('socket', onSocket) if (msg.socket === undefined) { // node.js 0.8 patch patchAssignSocket(msg, onSocket) } } /** * Attach the listener to the message. * * @param {object} msg * @return {function} * @private */ function attachListener(msg, listener) { var attached = msg.__onFinished // create a private single listener with queue if (!attached || !attached.queue) { attached = msg.__onFinished = createListener(msg) attachFinishedListener(msg, attached) } attached.queue.push(listener) } /** * Create listener on message. * * @param {object} msg * @return {function} * @private */ function createListener(msg) { function listener(err) { if (msg.__onFinished === listener) msg.__onFinished = null if (!listener.queue) return var queue = listener.queue listener.queue = null for (var i = 0; i < queue.length; i++) { queue[i](err, msg) } } listener.queue = [] return listener } /** * Patch ServerResponse.prototype.assignSocket for node.js 0.8. * * @param {ServerResponse} res * @param {function} callback * @private */ function patchAssignSocket(res, callback) { var assignSocket = res.assignSocket if (typeof assignSocket !== 'function') return // res.on('socket', callback) is broken in 0.8 res.assignSocket = function _assignSocket(socket) { assignSocket.call(this, socket) callback(socket) } } on-finished-2.3.0/package.json000066400000000000000000000015561253121555700162220ustar00rootroot00000000000000{ "name": "on-finished", "description": "Execute a callback when a request closes, finishes, or errors", "version": "2.3.0", "contributors": [ "Douglas Christopher Wilson ", "Jonathan Ong (http://jongleberry.com)" ], "license": "MIT", "repository": "jshttp/on-finished", "dependencies": { "ee-first": "1.1.1" }, "devDependencies": { "istanbul": "0.3.9", "mocha": "2.2.5" }, "engines": { "node": ">= 0.8" }, "files": [ "HISTORY.md", "LICENSE", "index.js" ], "scripts": { "test": "mocha --reporter spec --bail --check-leaks test/", "test-cov": "istanbul cover node_modules/mocha/bin/_mocha -- --reporter dot --check-leaks test/", "test-travis": "istanbul cover node_modules/mocha/bin/_mocha --report lcovonly -- --reporter spec --check-leaks test/" } } on-finished-2.3.0/test/000077500000000000000000000000001253121555700147045ustar00rootroot00000000000000on-finished-2.3.0/test/test.js000066400000000000000000000646531253121555700162370ustar00rootroot00000000000000 var assert = require('assert') var http = require('http') var net = require('net') var onFinished = require('..') describe('onFinished(res, listener)', function () { it('should invoke listener given an unknown object', function (done) { onFinished({}, done) }) describe('when the response finishes', function () { it('should fire the callback', function (done) { var server = http.createServer(function (req, res) { onFinished(res, done) setTimeout(res.end.bind(res), 0) }) sendget(server) }) it('should include the response object', function (done) { var server = http.createServer(function (req, res) { onFinished(res, function (err, msg) { assert.ok(!err) assert.equal(msg, res) done() }) setTimeout(res.end.bind(res), 0) }) sendget(server) }) it('should fire when called after finish', function (done) { var server = http.createServer(function (req, res) { onFinished(res, function () { onFinished(res, done) }) setTimeout(res.end.bind(res), 0) }) sendget(server) }) }) describe('when using keep-alive', function () { it('should fire for each response', function (done) { var called = false var server = http.createServer(function (req, res) { onFinished(res, function () { if (called) { socket.end() server.close() done(called !== req ? null : new Error('fired twice on same req')) return } called = req writerequest(socket) }) res.end() }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this) }) }) }) }) describe('when requests pipelined', function () { it('should fire for each request', function (done) { var count = 0 var responses = [] var server = http.createServer(function (req, res) { responses.push(res) onFinished(res, function (err) { assert.ifError(err) assert.equal(responses[0], res) responses.shift() if (responses.length === 0) { socket.end() return } responses[0].end('response b') }) onFinished(req, function (err) { assert.ifError(err) if (++count !== 2) { return } assert.equal(responses.length, 2) responses[0].end('response a') }) if (responses.length === 1) { // second request writerequest(socket) } req.resume() }) var socket server.listen(function () { var data = '' socket = net.connect(this.address().port, function () { writerequest(this) }) socket.on('data', function (chunk) { data += chunk.toString('binary') }) socket.on('end', function () { assert.ok(/response a/.test(data)) assert.ok(/response b/.test(data)) server.close(done) }) }) }) }) describe('when response errors', function () { it('should fire with error', function (done) { var server = http.createServer(function (req, res) { onFinished(res, function (err) { assert.ok(err) done() }) socket.on('error', noop) socket.write('W') }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this, true) }) }) }) it('should include the response object', function (done) { var server = http.createServer(function (req, res) { onFinished(res, function (err, msg) { assert.ok(err) assert.equal(msg, res) done() }) socket.on('error', noop) socket.write('W') }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this, true) }) }) }) }) describe('when the response aborts', function () { it('should execute the callback', function (done) { var client var server = http.createServer(function (req, res) { onFinished(res, done) setTimeout(client.abort.bind(client), 0) }) server.listen(function () { var port = this.address().port client = http.get('http://127.0.0.1:' + port) client.on('error', noop) }) }) }) describe('when calling many times on same response', function () { it('should not print warnings', function (done) { var server = http.createServer(function (req, res) { var stderr = captureStderr(function () { for (var i = 0; i < 400; i++) { onFinished(res, noop) } }) onFinished(res, done) assert.equal(stderr, '') res.end() }) server.listen(function () { var port = this.address().port http.get('http://127.0.0.1:' + port, function (res) { res.resume() res.on('close', server.close.bind(server)) }) }) }) }) }) describe('isFinished(res)', function () { it('should return undefined for unknown object', function () { assert.strictEqual(onFinished.isFinished({}), undefined) }) it('should be false before response finishes', function (done) { var server = http.createServer(function (req, res) { assert.ok(!onFinished.isFinished(res)) res.end() done() }) sendget(server) }) it('should be true after response finishes', function (done) { var server = http.createServer(function (req, res) { onFinished(res, function (err) { assert.ifError(err) assert.ok(onFinished.isFinished(res)) done() }) res.end() }) sendget(server) }) describe('when requests pipelined', function () { it('should have correct state when socket shared', function (done) { var count = 0 var responses = [] var server = http.createServer(function (req, res) { responses.push(res) onFinished(req, function (err) { assert.ifError(err) if (++count !== 2) { return } assert.ok(!onFinished.isFinished(responses[0])) assert.ok(!onFinished.isFinished(responses[1])) responses[0].end() responses[1].end() socket.end() server.close(done) }) if (responses.length === 1) { // second request writerequest(socket) } req.resume() }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this) }) }) }) it('should handle aborted requests', function (done) { var count = 0 var requests = 0 var server = http.createServer(function (req, res) { requests++ onFinished(req, function (err) { switch (++count) { case 1: assert.ifError(err) // abort the socket socket.on('error', noop) socket.destroy() break case 2: server.close(done) break } }) req.resume() if (requests === 1) { // second request writerequest(socket, true) } }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this) }) }) }) }) describe('when response errors', function () { it('should return true', function (done) { var server = http.createServer(function (req, res) { onFinished(res, function (err) { assert.ok(err) assert.ok(onFinished.isFinished(res)) done() }) socket.on('error', noop) socket.write('W') }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this, true) }) }) }) }) describe('when the response aborts', function () { it('should return true', function (done) { var client var server = http.createServer(function (req, res) { onFinished(res, function (err) { assert.ifError(err) assert.ok(onFinished.isFinished(res)) done() }) setTimeout(client.abort.bind(client), 0) }) server.listen(function () { var port = this.address().port client = http.get('http://127.0.0.1:' + port) client.on('error', noop) }) }) }) }) describe('onFinished(req, listener)', function () { describe('when the request finishes', function () { it('should fire the callback', function (done) { var server = http.createServer(function (req, res) { onFinished(req, done) req.resume() setTimeout(res.end.bind(res), 0) }) sendget(server) }) it('should include the request object', function (done) { var server = http.createServer(function (req, res) { onFinished(req, function (err, msg) { assert.ok(!err) assert.equal(msg, req) done() }) req.resume() setTimeout(res.end.bind(res), 0) }) sendget(server) }) it('should fire when called after finish', function (done) { var server = http.createServer(function (req, res) { onFinished(req, function () { onFinished(req, done) }) req.resume() setTimeout(res.end.bind(res), 0) }) sendget(server) }) }) describe('when using keep-alive', function () { it('should fire for each request', function (done) { var called = false var server = http.createServer(function (req, res) { var data = '' onFinished(req, function (err) { assert.ifError(err) assert.equal(data, 'A') if (called) { socket.end() server.close() done(called !== req ? null : new Error('fired twice on same req')) return } called = req res.end() writerequest(socket, true) }) req.setEncoding('utf8') req.on('data', function (str) { data += str }) socket.write('1\r\nA\r\n') socket.write('0\r\n\r\n') }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this, true) }) }) }) }) describe('when request errors', function () { it('should fire with error', function (done) { var server = http.createServer(function (req, res) { onFinished(req, function (err) { assert.ok(err) done() }) socket.on('error', noop) socket.write('W') }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this, true) }) }) }) it('should include the request objecy', function (done) { var server = http.createServer(function (req, res) { onFinished(req, function (err, msg) { assert.ok(err) assert.equal(msg, req) done() }) socket.on('error', noop) socket.write('W') }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this, true) }) }) }) }) describe('when the request aborts', function () { it('should execute the callback', function (done) { var client var server = http.createServer(function (req, res) { onFinished(req, done) setTimeout(client.abort.bind(client), 0) }) server.listen(function () { var port = this.address().port client = http.get('http://127.0.0.1:' + port) client.on('error', noop) }) }) }) describe('when calling many times on same request', function () { it('should not print warnings', function (done) { var server = http.createServer(function (req, res) { var stderr = captureStderr(function () { for (var i = 0; i < 400; i++) { onFinished(req, noop) } }) onFinished(req, done) assert.equal(stderr, '') res.end() }) server.listen(function () { var port = this.address().port http.get('http://127.0.0.1:' + port, function (res) { res.resume() res.on('close', server.close.bind(server)) }) }) }) }) describe('when CONNECT method', function () { it('should fire when request finishes', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('connect', function (req, socket, bodyHead) { var data = [bodyHead] onFinished(req, function (err) { assert.ifError(err) assert.equal(Buffer.concat(data).toString(), 'knock, knock') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') socket.end('pong') }) socket.write('HTTP/1.1 200 OK\r\n\r\n') }) req.on('data', function (chunk) { data.push(chunk) }) }) server.listen(function () { client = http.request({ hostname: '127.0.0.1', method: 'CONNECT', path: '127.0.0.1:80', port: this.address().port }) client.on('connect', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end('knock, knock') }) }) it('should fire when called after finish', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('connect', function (req, socket, bodyHead) { var data = [bodyHead] onFinished(req, function (err) { assert.ifError(err) assert.equal(Buffer.concat(data).toString(), 'knock, knock') socket.write('HTTP/1.1 200 OK\r\n\r\n') }) socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') onFinished(req, function (err) { socket.end('pong') }) }) req.on('data', function (chunk) { data.push(chunk) }) }) server.listen(function () { client = http.request({ hostname: '127.0.0.1', method: 'CONNECT', path: '127.0.0.1:80', port: this.address().port }) client.on('connect', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end('knock, knock') }) }) }) describe('when Upgrade request', function () { it('should fire when request finishes', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('upgrade', function (req, socket, bodyHead) { var data = [bodyHead] onFinished(req, function (err) { assert.ifError(err) assert.equal(Buffer.concat(data).toString(), 'knock, knock') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') socket.end('pong') }) socket.write('HTTP/1.1 101 Switching Protocols\r\n') socket.write('Connection: Upgrade\r\n') socket.write('Upgrade: Raw\r\n') socket.write('\r\n') }) req.on('data', function (chunk) { data.push(chunk) }) }) server.listen(function () { client = http.request({ headers: { 'Connection': 'Upgrade', 'Upgrade': 'Raw' }, hostname: '127.0.0.1', port: this.address().port }) client.on('upgrade', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end('knock, knock') }) }) it('should fire when called after finish', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('upgrade', function (req, socket, bodyHead) { var data = [bodyHead] onFinished(req, function (err) { assert.ifError(err) assert.equal(Buffer.concat(data).toString(), 'knock, knock') socket.write('HTTP/1.1 101 Switching Protocols\r\n') socket.write('Connection: Upgrade\r\n') socket.write('Upgrade: Raw\r\n') socket.write('\r\n') }) socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') onFinished(req, function (err) { socket.end('pong') }) }) req.on('data', function (chunk) { data.push(chunk) }) }) server.listen(function () { client = http.request({ headers: { 'Connection': 'Upgrade', 'Upgrade': 'Raw' }, hostname: '127.0.0.1', port: this.address().port }) client.on('upgrade', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end('knock, knock') }) }) }) }) describe('isFinished(req)', function () { it('should return undefined for unknown object', function () { assert.strictEqual(onFinished.isFinished({}), undefined) }) it('should be false before request finishes', function (done) { var server = http.createServer(function (req, res) { assert.ok(!onFinished.isFinished(req)) req.resume() res.end() done() }) sendget(server) }) it('should be true after request finishes', function (done) { var server = http.createServer(function (req, res) { onFinished(req, function (err) { assert.ifError(err) assert.ok(onFinished.isFinished(req)) done() }) req.resume() res.end() }) sendget(server) }) describe('when request data buffered', function () { it('should be false before request finishes', function (done) { var server = http.createServer(function (req, res) { assert.ok(!onFinished.isFinished(req)) req.pause() setTimeout(function () { assert.ok(!onFinished.isFinished(req)) req.resume() res.end() done() }, 10) }) sendget(server) }) }) describe('when request errors', function () { it('should return true', function (done) { var server = http.createServer(function (req, res) { onFinished(req, function (err) { assert.ok(err) assert.ok(onFinished.isFinished(req)) done() }) socket.on('error', noop) socket.write('W') }) var socket server.listen(function () { socket = net.connect(this.address().port, function () { writerequest(this, true) }) }) }) }) describe('when the request aborts', function () { it('should return true', function (done) { var client var server = http.createServer(function (req, res) { onFinished(res, function (err) { assert.ifError(err) assert.ok(onFinished.isFinished(req)) done() }) setTimeout(client.abort.bind(client), 0) }) server.listen(function () { var port = this.address().port client = http.get('http://127.0.0.1:' + port) client.on('error', noop) }) }) }) describe('when CONNECT method', function () { it('should be true immediately', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('connect', function (req, socket, bodyHead) { assert.ok(onFinished.isFinished(req)) assert.equal(bodyHead.length, 0) req.resume() socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') socket.end('pong') }) socket.write('HTTP/1.1 200 OK\r\n\r\n') }) server.listen(function () { client = http.request({ hostname: '127.0.0.1', method: 'CONNECT', path: '127.0.0.1:80', port: this.address().port }) client.on('connect', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end() }) }) it('should be true after request finishes', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('connect', function (req, socket, bodyHead) { var data = [bodyHead] onFinished(req, function (err) { assert.ifError(err) assert.ok(onFinished.isFinished(req)) assert.equal(Buffer.concat(data).toString(), 'knock, knock') socket.write('HTTP/1.1 200 OK\r\n\r\n') }) socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') socket.end('pong') }) req.on('data', function (chunk) { data.push(chunk) }) }) server.listen(function () { client = http.request({ hostname: '127.0.0.1', method: 'CONNECT', path: '127.0.0.1:80', port: this.address().port }) client.on('connect', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end('knock, knock') }) }) }) describe('when Upgrade request', function () { it('should be true immediately', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('upgrade', function (req, socket, bodyHead) { assert.ok(onFinished.isFinished(req)) assert.equal(bodyHead.length, 0) req.resume() socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') socket.end('pong') }) socket.write('HTTP/1.1 101 Switching Protocols\r\n') socket.write('Connection: Upgrade\r\n') socket.write('Upgrade: Raw\r\n') socket.write('\r\n') }) server.listen(function () { client = http.request({ headers: { 'Connection': 'Upgrade', 'Upgrade': 'Raw' }, hostname: '127.0.0.1', port: this.address().port }) client.on('upgrade', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end() }) }) it('should be true after request finishes', function (done) { var client var server = http.createServer(function (req, res) { res.statusCode = 405 res.end() }) server.on('upgrade', function (req, socket, bodyHead) { var data = [bodyHead] onFinished(req, function (err) { assert.ifError(err) assert.ok(onFinished.isFinished(req)) assert.equal(Buffer.concat(data).toString(), 'knock, knock') socket.write('HTTP/1.1 101 Switching Protocols\r\n') socket.write('Connection: Upgrade\r\n') socket.write('Upgrade: Raw\r\n') socket.write('\r\n') }) socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'ping') socket.end('pong') }) req.on('data', function (chunk) { data.push(chunk) }) }) server.listen(function () { client = http.request({ headers: { 'Connection': 'Upgrade', 'Upgrade': 'Raw' }, hostname: '127.0.0.1', port: this.address().port }) client.on('upgrade', function (res, socket, bodyHead) { socket.write('ping') socket.on('data', function (chunk) { assert.equal(chunk.toString(), 'pong') socket.end() server.close(done) }) }) client.end('knock, knock') }) }) }) }) function captureStderr(fn) { var chunks = [] var write = process.stderr.write process.stderr.write = function write(chunk, encoding) { chunks.push(new Buffer(chunk, encoding)) } try { fn() } finally { process.stderr.write = write } return Buffer.concat(chunks).toString('utf8') } function noop() {} function sendget(server) { server.listen(function onListening() { var port = this.address().port http.get('http://127.0.0.1:' + port, function onResponse(res) { res.resume() res.on('close', server.close.bind(server)) }) }) } function writerequest(socket, chunked) { socket.write('GET / HTTP/1.1\r\n') socket.write('Host: localhost\r\n') socket.write('Connection: keep-alive\r\n') if (chunked) { socket.write('Transfer-Encoding: chunked\r\n') } socket.write('\r\n') }